Add cacheOnly option to StoreReadRequest #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Brawner <[email protected]>
Signed-off-by: William Brawner <[email protected]>
wbrawner
commented
Nov 14, 2023
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStore.kt
Outdated
Show resolved
Hide resolved
|
@matt-ramotar I seem to be unable to request a review from you for some reason. Sorry if this is already on your radar, just wanted to make sure you saw it! |
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStore.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: William Brawner <[email protected]>
matt-ramotar
reviewed
Dec 1, 2023
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreReadRequest.kt
Outdated
Show resolved
Hide resolved
matt-ramotar
reviewed
Dec 1, 2023
store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStore.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: William Brawner <[email protected]>
…ata sources configured Signed-off-by: William Brawner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at implementing the cache-only reads for the
StoreReadRequest. I thought sending backNoNewDatamade more sense thanErrorsince reading from an empty or invalid cache isn't exactly a problem per-se. Of note is that this doesn't hit the disk either, but I think that's fine since the original request was to only hit the cacheThis closes #457